Repository navigation
tesla_preap: restore regen demand margins - #30
Merged
Merged
Conversation
The prompt sound still repeats until the warning clears. Put the trigger back to 0.2 m/s² below the envelope and 0.3s of evidence. Bump opendbc to the matching monitor thresholds.
openpilot scons never entered opendbc, so libsafety.so and the generated honda DBCs were missing and unit tests died on import. Find openssl without brew on PATH. NAP opendbc still names the hyundai safety bit CANFD_LKA_STEERING.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the repeating regen prompt sound. Restore the demand-check margins (0.2 m/s² / 0.3s) and bump opendbc so the car-side monitor matches.
Depends on NotAutopilot/opendbc tesla-preap/regen-prompt-original.